voc/publishing
35
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

WIP: feat/webhook-cleanup-39c3 #2

Draft
andi wants to merge 14 commits from feat/webhook-cleanup-39c3 into main
pull from: feat/webhook-cleanup-39c3
merge into: voc:main
Conversation 1 Commits 14 Files changed 9 +242 -66
andi commented 2026-01-21 21:19:57 +00:00
Owner
Copy link
No description provided.
feat: draft to cleanup failed webhook reports 39C3 hub
Some checks failed
Makefile CI / isort (pull_request) Has been cancelled
Details
Makefile CI / ruff (pull_request) Has been cancelled
Details
c92e634292
kunsi requested changes 2026-01-23 21:30:11 +00:00
config.example.toml
@ -35,3 +40,1 @@
[voctoweb]
# e.g. https://exmaple.com/api/ - with trailing slash
api_url = "<voctoweb api url>"
enable_default = true
kunsi commented 2026-01-23 21:18:57 +00:00
Owner
Copy link

This is no longer used, use [defaults] below

This is no longer used, use `[defaults]` below
scripts/sync-tracker-with-hub.py
@ -0,0 +17,4 @@
tracker = TrackerClient()
project = '39c3'
kunsi commented 2026-01-23 21:29:13 +00:00
Owner
Copy link

Do we really need to have one-shot scripts like these in this repository?

Do we really need to have one-shot scripts like these in this repository?
kunsi commented 2026-01-23 21:30:00 +00:00
Owner
Copy link

If yes, it should atleast take the relevant information fron the config file and command line options instead of hard-coding them.

If yes, it should atleast take the relevant information fron the config file and command line options instead of hard-coding them.
andi commented 2026-01-26 19:48:17 +00:00
Author
Owner
Copy link

Yeah, that was the idea – that was one of the reasons why this was still marked as draft

Yeah, that was the idea – that was one of the reasons why this was still marked as draft
andi marked this conversation as resolved
scripts/sync-tracker-with-hub.py Outdated
@ -0,0 +51,4 @@
print(json.dumps(webhook._get_json(ticket), indent=2))
exit()
kunsi commented 2026-01-23 21:20:26 +00:00
Owner
Copy link

What does this do, and why do we have code after this?

What does this do, and why do we have code after this?
andi marked this conversation as resolved
scripts/sync-tracker-with-hub.py Outdated
@ -0,0 +72,4 @@
if __name__ == "__main__":
sync_tracker_with_hub()
kunsi commented 2026-01-23 21:21:26 +00:00
Owner
Copy link

In general, this script looks like a WIP commit, we should try to not have that in the main branch.

In general, this script looks like a WIP commit, we should try to not have that in the main branch.
andi marked this conversation as resolved
voctopublish/api_client/webhook_client.py
@ -104,0 +105,4 @@
if not config:
config = ticket.config
if not voctoweb_filename:
voctoweb_filename = ticket.filename
kunsi commented 2026-01-23 21:22:59 +00:00
Owner
Copy link

Are these identical? If yes, we can just remove passing this in. If not, it's not a great fallback value.

Same for language below.

Are these identical? If yes, we can just remove passing this in. If not, it's not a great fallback value. Same for `language` below.
andi commented 2026-01-26 19:51:06 +00:00
Author
Owner
Copy link

for the default case they are identical, as far as I understand the code there should be an option to overwrite the default filename for specific cases e.g. single-language MP4s

for the default case they are identical, as far as I understand the code there should be an option to overwrite the default filename for specific cases e.g. single-language MP4s
voctopublish/api_client/webhook_client.py
@ -129,2 +137,2 @@
).split("/", 2)
thumb_url = f"https:/{thumb_path[1]}/media/{thumb_path[2]}"
)
tpc = thumb_path.split("/", 2)
kunsi commented 2026-01-23 21:23:39 +00:00
Owner
Copy link

We should aim for readable variables in newly added code. tpc is not very readable.

We should aim for readable variables in newly added code. `tpc` is not very readable.
voctopublish/model/ticket_module.py Outdated
@ -105,2 +106,4 @@
return False
def __str__(self):
return super().__str__() + " " +json.dumps(vars(self), indent=2)
kunsi commented 2026-01-23 21:24:58 +00:00
Owner
Copy link

Dumping a big json blob is not exactly whay i would expect in __str__(). Ideally, put the JSON into a new method called to_json() or something like that.

Dumping a big json blob is not exactly whay i would expect in `__str__()`. Ideally, put the JSON into a new method called `to_json()` or something like that.
voctopublish/voctopublish.py
@ -43,3 +44,3 @@
from tools.thumbnails import ThumbnailGenerator
MY_PATH = os.path.abspath(os.path.dirname(__file__))
MY_PATH = os.path.abspath(os.path.dirname(os.path.dirname(__file__)))
kunsi commented 2026-01-23 21:27:21 +00:00
Owner
Copy link

This was intentional. We should encourage users to use environment variables instead.

This was intentional. We should encourage users to use environment variables instead.
voctopublish/voctopublish.py Outdated
@ -92,3 +94,3 @@
self.ticket_type = "recording"
self.to_state = "recording"
else:
elif self.worker_type != "other":
kunsi commented 2026-01-23 21:27:43 +00:00
Owner
Copy link

What is an 'other' worker?

What is an 'other' worker?
andi commented 2026-01-26 19:52:28 +00:00
Author
Owner
Copy link

any other worker which does not download, or publish a ticket. E.g. relive, or fixup scripts like the one we are adding in this PR.

any other worker which does not download, or publish a ticket. E.g. relive, or fixup scripts like the one we are adding in this PR.
experiment(ticket): dict-like access to raw properties
Some checks failed
Makefile CI / isort (pull_request) Has been cancelled
Details
Makefile CI / ruff (pull_request) Has been cancelled
Details
fb29152c4d
andi changed title from DRAFT: feat/webhook-cleanup-39c3 to WIP: DRAFT: feat/webhook-cleanup-39c3 2026-01-26 19:52:58 +00:00
andi changed title from WIP: DRAFT: feat/webhook-cleanup-39c3 to WIP: feat/webhook-cleanup-39c3 2026-01-26 19:53:04 +00:00
Some checks failed
Makefile CI / isort (pull_request) Has been cancelled
Details
Makefile CI / ruff (pull_request) Has been cancelled
Details
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/webhook-cleanup-39c3:feat/webhook-cleanup-39c3
git switch feat/webhook-cleanup-39c3

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff feat/webhook-cleanup-39c3
git switch feat/webhook-cleanup-39c3
git rebase main
git switch main
git merge --ff-only feat/webhook-cleanup-39c3
git switch feat/webhook-cleanup-39c3
git rebase main
git switch main
git merge --no-ff feat/webhook-cleanup-39c3
git switch main
git merge --squash feat/webhook-cleanup-39c3
git switch main
git merge --ff-only feat/webhook-cleanup-39c3
git switch main
git merge feat/webhook-cleanup-39c3
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
kunsi
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
voc/publishing!2
No description provided.